[PATCH] D48017: AMDGPU: Select MIMG instructions manually in SITargetLowering

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 11 10:34:17 PDT 2018


rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

Thank you! I am in favor of this change even despite what we have discussed today. If we eventually want to create target ISD nodes it could be done on top of it and separately, but currently I see no such need.
A separate note: SIISelLowering.cpp has really overgrown, it is already about 8000 lines. Maybe we shall consider splitting it into separate pieces as a separate change. Like this stuff is something like SIImageLowering.cpp.


Repository:
  rL LLVM

https://reviews.llvm.org/D48017





More information about the llvm-commits mailing list