[PATCH] D31528: [ELF][MIPS] Multi-GOT implementation

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 10 11:15:39 PDT 2018


arichardson accepted this revision.
arichardson added inline comments.


================
Comment at: ELF/DriverUtils.cpp:31
 using namespace llvm;
+using namespace llvm::opt;
 using namespace llvm::sys;
----------------
atanasyan wrote:
> grimar wrote:
> > Seems unused.
> Without this line I get the following error message because Options.td includes the `HelpHidden` flag:
> ```
> In file included from /home/simon/work/lld/git/tools/lld/ELF/DriverUtils.cpp:48:
> tools/lld/ELF/Options.inc:201:87: error: use of undeclared identifier 'HelpHidden'; did you mean 'llvm::opt::HelpHidden'?
> ```
It seems like this is now already included two lines further down 


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D31528





More information about the llvm-commits mailing list