[PATCH] D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common

Peter Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 10 09:53:11 PDT 2018


Lekensteyn updated this revision to Diff 150653.
Lekensteyn marked 7 inline comments as done.
Lekensteyn retitled this revision from "[sanitizer] Move fgets, fputs and puts into sanitizer_common" to "[sanitizer] Add fgets, fputs and puts into sanitizer_common".
Lekensteyn edited the summary of this revision.
Lekensteyn added a comment.

Changes:

- Restore previous `strlen(s)+1` check for `fgets(s, size, fp)` as suggested.
- Add MSAN, TSAN test coverage for bad cases.
- Add `sanitizer_common` tests for good cases.


https://reviews.llvm.org/D46545

Files:
  lib/esan/esan_interceptors.cpp
  lib/msan/msan_interceptors.cc
  lib/sanitizer_common/sanitizer_common_interceptors.inc
  lib/sanitizer_common/sanitizer_platform_interceptors.h
  lib/tsan/rtl/tsan_interceptors.cc
  test/asan/TestCases/Posix/fgets_fputs.cc
  test/msan/fgets_fputs.cc
  test/sanitizer_common/TestCases/Posix/fgets.cc
  test/sanitizer_common/TestCases/Posix/fputs_puts.cc
  test/tsan/race_on_fputs.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46545.150653.patch
Type: text/x-patch
Size: 9406 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180610/1f0e168f/attachment.bin>


More information about the llvm-commits mailing list