[PATCH] D47972: update simplifyUnsignedRangeCheck function's test case.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 10 09:39:42 PDT 2018


lebedev.ri added a comment.

@HLJ2009 just in case, let me reiterate:
These tests need to be generated for the **svn trunk** version of llvm, **not** https://reviews.llvm.org/D47922.
They should be (when accepted) **committed before** the dependent revision.
They need to have good coverage, ideally for all the previously-missing cases, and for **all the cases that will be affected** by the dependent revision. (well, not //all//, obviously)
Then, https://reviews.llvm.org/D47922 needs to be rebased **ontop of this change** (and do mark it as a dependent in phabricator, to signify it), and the effect of the code change should be visible in the tests.


Repository:
  rL LLVM

https://reviews.llvm.org/D47972





More information about the llvm-commits mailing list