[PATCH] D47890: [Polly][zorg] Enable GPGPU Codegen on the builders only if NVPTX is an LLVM target
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 8 11:07:44 PDT 2018
Meinersbur added a comment.
In https://reviews.llvm.org/D47890#1126141, @philip.pfaffe wrote:
> That's a way to find the first matching element and decide whether there is one in a compact functional way. Do you think it's stylistically questionable?
IMHO it is functionally identical to `any('LLVM_TARGETS_TO_BUILD' in A and 'NVPTX' in A for A in extraCmakeArgs)` which is even more compact. Why does your version add an `if`-constraint to the generator when `any` ignores false-ish elements anyway?
https://reviews.llvm.org/D47890
More information about the llvm-commits
mailing list