[PATCH] D47922: unsigned foo(unsigned x, unsigned y) { return x > y && x != 0; } should fold to x > y

Li Jia He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 8 07:18:39 PDT 2018


HLJ2009 added a comment.

In https://reviews.llvm.org/D47922#1126437, @spatel wrote:

> Re: test location
>  This transform is in InstSimplify, so it should have tests under test/Transforms/InstSimplify. Ie, we shouldn't need to run -instcombine to demonstrate the fold.
>  Have a look in Transforms/InstSimplify/AndOrXor.ll for existing tests. You may want to do some preliminary cleanup if the tests are scattered between InstCombine and InstSimplify.


hi ,

  I found that there are several test cases not written. Do I need to add them now? Or do I write it alone and submit it again?


Repository:
  rL LLVM

https://reviews.llvm.org/D47922





More information about the llvm-commits mailing list