[PATCH] D47713: [AArch64][SVE] Asm: Support for INC/DEC (scalar) instructions.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 8 06:17:48 PDT 2018


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks OK to me.



================
Comment at: test/MC/AArch64/SVE/decb.s:118
+
+decb    x0, #14
+// CHECK-INST: decb    x0, #14
----------------
I think you had a similar discussion with Florian about testing ranges of immediates in one of the other patches.
Looks like your checking all values between:

decb x0, #14
...
decb x0, #28

I certainly don't mind, but was just wondering if there's an added value (perhaps I am missing something).


================
Comment at: test/MC/AArch64/SVE/decd.s:118
+
+decd    x0, #14
+// CHECK-INST: decd    x0, #14
----------------
Same here, and in the other variants.


https://reviews.llvm.org/D47713





More information about the llvm-commits mailing list