[PATCH] D47730: [SelectionDAG]Reduce masked data movement chains and memory access widths pt2

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13050
+SDNode *
+DAGCombiner::shrinkLoadShiftOrStoreWithLoadNewStore(StoreSDNode *Store) {
+  SDValue OR = Store->getValue();
----------------
Can this not be implemented in, or as a helper function for, ReduceLoadOpStoreWidth? That function is already performing safety checks and handling the load and store creation correctly. It looks like it needs help understanding a shifted operand to the OR, instead of just a constant.


================
Comment at: lib/Transforms/Utils/SimplifyIndVar.cpp:787
 
-      Value *NewOper = foldIVUser(UseInst, IVOperand);
+      Value *NewOper = foldIVUser(UseOper.first, IVOperand);
       if (!NewOper)
----------------
Why these changes?


https://reviews.llvm.org/D47730