[PATCH] D45556: [DebugInfo] Generate DWARF debug information for labels.

Hsiangkai Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 7 23:27:31 PDT 2018


HsiangKai added a comment.

In https://reviews.llvm.org/D45556#1125471, @aprantl wrote:

> This is not super important, but: contrary to to DBG_VALUE intrinsics, DBG_LABELs don't have live ranges associated with them. I wonder if we really need to rename DbgValueHistoryCalculator. We're not calculating any "history" of labels, do we?


I need to get the mapping between “InlinedLabel” and dbg.label intrinsic MI. I put the operation in calculateDbgValueHistory(). Because calculateDbgValueHistory() no longer only calculates DbgValueHistoryMap, it also calculates DbgLabelInstrMap. So, I rename it.

Should I put DbgLabelInstrMap calculation in a new file, maybe called DbgLabelInstrCalculator.cpp/h?


Repository:
  rL LLVM

https://reviews.llvm.org/D45556





More information about the llvm-commits mailing list