[PATCH] D47791: Initial support for Hexagon target.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/Hexagon.cpp:46-47
+  for (size_t Bit = 0; Bit != 32; ++Bit) {
+    auto ValBit = (Data >> Off) & 1;
+    auto MaskBit = (Mask >> Bit) & 1;
+    if (MaskBit) {
----------------
Please do not use `auto` as well. As I said, if you read other code in this directory or other directories in lld, you'd notice that we normally don't use `auto` unless its type is obvious (i.e. to avoid a repetition like `Foo *X = dyn_cast<Foo>(Y)`). I'd be more careful to follow the convention by reading code first.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47791