[PATCH] D47566: AMDHSA: Code object v3 updates

[Tony Tye via Phabricator via llvm-commits]

t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: include/llvm/Support/AMDHSAKernelDescriptor.h:50
+
+// Floating point rounding modes. Must be kept backwards compatible.
+enum : uint8_t {
----------------
kzhuravl wrote:
> t-tye wrote:
> > What does "Must be kept backwards compatible." mean? Arn't these just the meaning of the values? Or is the issue that they may change value on different targets in the future?
> May change value in future.
Suggest:

```
// Floating point rounding modes. Must match hardware definition.
```




https://reviews.llvm.org/D47566