[PATCH] D47525: [TableGen] Make DAGInstruction own Pattern to avoid leaking it.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 7 14:14:29 PDT 2018


craig.topper added inline comments.


================
Comment at: utils/TableGen/CodeGenDAGPatterns.cpp:3575
+  DAGInstruction TheInst(std::move(I), Results, Operands, InstImpResults);
+  DAGInsts.emplace(
+      std::make_pair(InstPattern->getRecord(), std::move(TheInst)));
----------------
Why doesn't insert work? There should be an rvalue pair version.


https://reviews.llvm.org/D47525





More information about the llvm-commits mailing list