[PATCH] D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution

Evgeny Stupachenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 7 14:01:23 PDT 2018


evstupac added a comment.

In https://reviews.llvm.org/D30527#1125545, @lebedev.ri wrote:

> I think it might help if the motivational part would be specified in the differential's description.
>
> Why is this wanted?


It was requested by Quentin in https://reviews.llvm.org/D29862

> With what does this help?

It potentially helps to avoid different results on different CPUs due to use of floating point arithmetic.

> Does this change affect anything?

No. It is NFC on all CPUs I have in my pool.

> Can the change be tested?

I don't see how.

> etc




Repository:
  rL LLVM

https://reviews.llvm.org/D30527





More information about the llvm-commits mailing list