[PATCH] D47901: [WebAssembly] Update .debug_line section PC addresses during LEB optimization

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 7 12:59:49 PDT 2018


ruiu added inline comments.


================
Comment at: wasm/InputChunks.cpp:95
 
+static void updateDebugLine(ObjFile *File, const ArrayRef<uint8_t> &data,
+                            const std::vector<WasmRelocation> &Relocations,
----------------
I haven't read this function yet, but this function is not OK because it is too long and doesn't have comment to help readers understand it. Please read other code in lld carefully and follow local conventions, and then reorganize the code in this patch, so that the first time reader can easily understand your code.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47901





More information about the llvm-commits mailing list