[PATCH] D47289: [scudo] Improve the scalability of the shared TSD model

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 7 11:30:14 PDT 2018


dvyukov added a comment.

What exactly versions did you test? Current vs removing precedence and trylocking all caches? If yes, then it's unclear what factor affects performance as we change 2 things at the same time. So I would also try:

1. Remove precedence, but scan only 4 random caches, then lock the current cache.
2. Remove precedence, but scan only 4 random caches, then lock a random cache.
3. Keep precedence but scan all caches.

I would not expect 3 to be faster, but who knows.
Looking at your results I think it mostly needs to be tested on t-test1, because it should not affect android with 2/4 caches.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D47289





More information about the llvm-commits mailing list