[PATCH] D47805: [AMDGPU] Improve reciprocal handling

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 6 12:16:16 PDT 2018


rampitec added inline comments.


================
Comment at: test/CodeGen/AMDGPU/fdiv32-to-rcp-folding.ll:98-101
+; GCN-DENORM-DAG: v_mul_f32_e32 v{{[0-9]+}}, s{{[0-9]+}}, v{{[0-9]+}}
+; GCN-DENORM-DAG: v_mul_f32_e32 v{{[0-9]+}}, s{{[0-9]+}}, v{{[0-9]+}}
+; GCN-DENORM-DAG: v_mul_f32_e32 v{{[0-9]+}}, s{{[0-9]+}}, v{{[0-9]+}}
+; GCN-DENORM-DAG: v_mul_f32_e32 v{{[0-9]+}}, s{{[0-9]+}}, v{{[0-9]+}}
----------------
arsenm wrote:
> This will only effectively check for one, although I think there's a FileCheck patch out for review to fix this
Then after FileCheck imorived the will test mire than now. It is really impossible to make reliable non-dag checks here in presence of two schedulers.


https://reviews.llvm.org/D47805





More information about the llvm-commits mailing list