[PATCH] D47836: Use SmallPtrSet explicitly for SmallSets with pointer types (NFC).

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In https://reviews.llvm.org/D47836#1124278, @craig.topper wrote:

> SmallSet<T*> has a template specialization that just inherits from SmallPtrSet.


*nod* So my question was "why ever write SmallPtrSet, why not just write SmallSet<T*> everywhere"?

> As to the question about giong the other direction and using SmallSet everywehre. The real SmallSet class doesn't implement begin/end while SmallPtrSet does so we shouldn't convert everything that direction.

Oh, that's curious - though I'm going to guess that there's at least some uses that don't distinguish between how they name the type when they use begin/end, they probably just use it and it works.


https://reviews.llvm.org/D47836