[PATCH] D47831: [DAGCombiner] Recognize more patterns for ABS

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 6 15:54:29 PDT 2018


spatel added a comment.

Here's the instcombine patch:
https://reviews.llvm.org/rL334137

If we want to keep going with a DAG patch, we'll need codegen tests. A basic x86 example is shown in PR36036.

A more involved case with multiple uses of the intermediate values would thwart the IR transform, so that would be a good test for either this patch or the value tracking + SelectionDAGBuilder suggestion.


Repository:
  rL LLVM

https://reviews.llvm.org/D47831





More information about the llvm-commits mailing list