[PATCH] D47833: [CMake] Pass additional CMake tools to external projects

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/cmake/modules/LLVMExternalProjectUtils.cmake:111
+    if(lld IN_LIST TOOLCHAIN_TOOLS)
+      list(APPEND compiler_args -DCMAKE_LINKER=${LLVM_RUNTIME_OUTPUT_INTDIR}/ld.lld)
+    endif()
----------------
smeenai wrote:
> Do we only care about ELF?
Ideally this would support other platforms as well, but there are other bits in this function that would need to be probably changed as well, e.g. `CMAKE_C_COMPILER` and `CMAKE_CXX_COMPILER` should be also pointing to `clang-cl` when target system is Windows, so I'm not sure if it's worth doing all that in this patch?


Repository:
  rL LLVM

https://reviews.llvm.org/D47833