[PATCH] D47725: [SelectionDAG] Provide default expansion for rotates

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 5 14:02:33 PDT 2018


efriedma added a comment.

Currently it's impossible to reach LegalizeDAG with an integer that isn't a power of two (only power-of-two integers can be specified as legal types), but I guess it's better to future-proof.

I like to see a test with explicit CHECK lines for the assembly generated using the legalization in SelectionDAGLegalize::ExpandNode, so we'll know if something changes.


Repository:
  rL LLVM

https://reviews.llvm.org/D47725





More information about the llvm-commits mailing list