[PATCH] D47736: AMDHSA Code Object v3 assembler syntax update

[Scott Linder via Phabricator via llvm-commits]

scott.linder updated this revision to Diff 150029.
scott.linder added a comment.

Address feedback

I am still not sure where "quote a string so that MC understands it" is; there is a static function PrintQuotedString in lib/MC/MCAsmStreamer.cpp that should maybe be moved somewhere else? For now I do what we do for other quoted strings (quote but not escape).


https://reviews.llvm.org/D47736

Files:
  docs/AMDGPUUsage.rst
  lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
  lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
  lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h
  lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
  lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
  test/MC/AMDGPU/hsa-diag-v3.s
  test/MC/AMDGPU/hsa-v3.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47736.150029.patch
Type: text/x-patch
Size: 59250 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180605/0f67c63b/attachment.bin>