[PATCH] D47750: [llvm-strip] Expose --discard-all option

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 5 12:37:17 PDT 2018


alexshap added inline comments.


================
Comment at: test/tools/llvm-objcopy/discard-all.test:14
+# Verify that llvm-strip modifies the symbol table the same way.
+# RUN: llvm-strip -d --discard-all %t
+# RUN: cmp %t2 %t
----------------
jhenderson wrote:
> Why is the -d here?
> 
> Could you also test -x with llvm-strip, please?
>Why is the -d here?
@jhenderson - otherwise strip will remove the symbol table and we won't be able to test how it's getting modified.


Repository:
  rL LLVM

https://reviews.llvm.org/D47750





More information about the llvm-commits mailing list