[PATCH] D47703: [Mips] Remove uneeded variants of ADDC/ADDE lowering

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 5 07:59:05 PDT 2018


sdardis accepted this revision.
sdardis added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Target/Mips/MipsSEISelLowering.cpp:108
+
+    if (Subtarget.hasMips32r2()) {
+      setOperationAction(ISD::ADDC, MVT::i32, Legal);
----------------
deadalnix wrote:
> sdardis wrote:
> > This needs to be Subtarget.hasDSP() && Subtarget.hasMips32r2().
> This is what it is doing, see the if around the whole section.
D'oh. Missed that.


Repository:
  rL LLVM

https://reviews.llvm.org/D47703





More information about the llvm-commits mailing list