[PATCH] D47763: [X86] Explicitly mark unsupported zmm classes in scheduling models.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86SchedHaswell.td:144
+defm : HWWriteResPair<WriteFSqrt64Z, [], 0>;
+defm : HWWriteResPair<WriteFSqrtZ, [], 0>;
+}  // Unsupported
----------------
This is going to be a problem for KNL.......


================
Comment at: lib/Target/X86/X86SchedSandyBridge.td:104
+defm : SBWriteResPair<WriteFSqrt64Z, [SBPort0,SBPort05,SBFPDivider], 45, [2,1,44], 3, 7>;
+defm : SBWriteResPair<WriteFSqrtZ,   [SBPort0,SBPort05,SBFPDivider], 29, [2,1,28], 3, 7>;
+
----------------
Keep the comment, but I'd probably recommend just leaving these in their original places (possibly with an "// Unsupported" next to it?) for comparison to "supported" cases - I typically just copied the YMM values for the ZMM cases - not great but it at least had consistency........


================
Comment at: lib/Target/X86/X86ScheduleAtom.td:83
+defm : AtomWriteResPair<WriteFSqrt64Z, [], []>;
+defm : AtomWriteResPair<WriteFSqrtZ, [], []>;
+}  // Unsupported
----------------
There are a lot more than this that aren't supported in this model - move them too?


================
Comment at: lib/Target/X86/X86ScheduleBtVer2.td:162
+defm : JWriteResIntPair<WriteFSqrt64Z, [], 0>;
+defm : JWriteResIntPair<WriteFSqrtZ, [], 0>;
+}  // Unsupported
----------------
There are a lot more than this that aren't supported in this model - move them too?


================
Comment at: lib/Target/X86/X86ScheduleSLM.td:82
+defm : SLMWriteResPair<WriteFSqrt64Z, [], 0>;
+defm : SLMWriteResPair<WriteFSqrtZ, [], 0>;
+}  // Unsupported
----------------
There are a lot more than this that aren't supported in this model - move them too?


Repository:
  rL LLVM

https://reviews.llvm.org/D47763