[PATCH] D47467: [IR] Begin removal of TerminatorInst by removing successor manipulation.

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 5 02:49:52 PDT 2018


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM

> These are likely to be quite mechanical, and I suspect are probably best done with post-commit review.

I agree. The others sound sufficiently mechanical for post-commit review.



================
Comment at: llvm/include/llvm/IR/CFG.h:195
+
+  inline BasicBlock *operator*() const { return Inst->getSuccessor(Idx); }
+
----------------
Should BasicBlock here be BlockT?


================
Comment at: llvm/include/llvm/IR/CFG.h:198
+  // We use the basic block pointer directly for operator->.
+  inline BasicBlock *operator->() const { return operator*(); }
+
----------------
Same here?


Repository:
  rL LLVM

https://reviews.llvm.org/D47467





More information about the llvm-commits mailing list