[PATCH] D47695: [XRay][compiler-rt] Remove reliance on C++ ABI from BufferQueue
Dean Michael Berris via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 4 20:40:32 PDT 2018
dberris added inline comments.
================
Comment at: compiler-rt/lib/xray/xray_buffer_queue.cc:33
+
+static void **initOwnedBuffers(size_t N) {
+ auto A = reinterpret_cast<void **>(
----------------
kpw wrote:
> Can you template the array init and still be ABI compliant? Other than initialization, these are identical other than the type and that could be traited.
>
> If you can't or feel that would be less readable, feel free to resolve this comment.
Thanks! Much more readable with a template indeed.
https://reviews.llvm.org/D47695
More information about the llvm-commits
mailing list