[PATCH] D47727: [WebAssembly] Fix .td files after rL333900

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 4 12:43:57 PDT 2018


nhaehnle added a comment.

My apologies. I thought I was testing all targets, but clearly I wasn't, and I didn't see buildbot failures.

The background is that `defm` and `defm ""` now both have well-defined but different meanings. The TableGen/LangRef.rst says this as well, but the summary is:

1. `defm ""` behaves like any other `defm`, concatenating names by default, just with an empty concatenation.
2. `defm` without a name generates a new, globally unique name and uses that (the name takes the form of "anonymous_NNNN" right now, but that's an implementation detail).

Previously, `defm` would sometimes behave like it does now, and sometimes like `defm ""` behaves now, and which behavior it actually took depended on a spooky-action-at-a-distance rule that never really made sense to begin with (it clearly just grew historically).

Again, my apologies for the inconvenience.


Repository:
  rL LLVM

https://reviews.llvm.org/D47727





More information about the llvm-commits mailing list