[PATCH] D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 4 11:47:07 PDT 2018


efriedma added a comment.

getImpl is private because it's a confusing API; it's very easy to mess up endianness, and ConstantDataArray doesn't work with arbitrary LLVM types (only i8/i16/i32/i64/float/double).  This wrapper isn't really much better.

What use case isn't covered by the existing get() APIs?


Repository:
  rL LLVM

https://reviews.llvm.org/D47706





More information about the llvm-commits mailing list