[PATCH] D47653: [lit, pdb] Fix two failing PDB tests on Windows

Stella Stamenova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 4 09:52:19 PDT 2018


stella.stamenova added a comment.

In https://reviews.llvm.org/D47653#1120508, @labath wrote:

> > newer DIA SDKs annotate the function names with their return type and inputs
>
> Does this mean that the tests will now fail for people who happen to have older/different versions of MSVS/DIA SDK installed?


It should not fail for people with newer versions because I updated the matching pattern to include both.

One thing I did notice, though, is that the order in which some of the symbol sections are generated differs but FileCheck looks for matches in the order in the test file. Do you know of a way to make it match either order? Right now the section for FuncSymbols.cpp is sometimes before and sometimes after the section for FuncSymbolsTestMain.cpp


Repository:
  rL LLVM

https://reviews.llvm.org/D47653





More information about the llvm-commits mailing list