[PATCH] D47431: TableGen: Allow foreach in multiclass to depend on template args

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham added inline comments.


================
Comment at: test/TableGen/foreach-multiclass.td:20
+
+// CHECK: def B2-1 {
+// CHECK:   int val = 6;
----------------
Hmm, this is generating `-print-records` output that's not legal tablegen input – the minus sign isn't a valid character in identifier names as far as the lexer's concerned. Is that a problem? I think in this situation I'd have expected a complaint from tablegen ("this concatenation would generate an illegal record name"), rather than silently generating this kind of unexpected output which I could imagine causing knock-on confusion in an unwary backend.


Repository:
  rL LLVM

https://reviews.llvm.org/D47431