[PATCH] D47604: [Polly] Add isl C++ list iterators

Siddharth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 4 03:11:18 PDT 2018


bollu added a comment.

This might be too much to ask for, but is it possible to `report_fatal_error()` at the earliest when accessing out of bounds using the iterator? If ISL performs inbounds checks, then disregard this.

Also, I was probably out of the loop for the API discussion. When did we settle on getting a `list` out of a `set`, `map`, etc. and then iterating over the `list`?

I thought the eventual API was trying to settle into something like:

  for (isl::set Set : USet) {...}

rather than

  for (isl::set Set : USet.get_set_list()) {...}


Repository:
  rPLO Polly

https://reviews.llvm.org/D47604





More information about the llvm-commits mailing list