[PATCH] D47696: [XRay][compiler-rt] Refactor recursion guard for Basic and FDR Mode

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 3 23:06:46 PDT 2018


dberris created this revision.
dberris added reviewers: kpw, eizan.
Herald added a reviewer: jfb.

This change merges the FDR mode implementation into a single file, and
shares the recursion guard implementation used in both the Basic and FDR
mode implementations.

Along the way we have some cleanups in the FDR logging implementation,
to remove 'inline' in favour of 'static' for functions. We also the
unnecessary __sanitizer:: prefix to memory operations, and uses the
internal_* version of the std::* memory operations (memset, memcpy,
etc.).

This is related to the work to address http://llvm.org/PR32274.

Depends on https://reviews.llvm.org/D47695.


https://reviews.llvm.org/D47696

Files:
  compiler-rt/lib/xray/xray_basic_logging.cc
  compiler-rt/lib/xray/xray_fdr_logging.cc
  compiler-rt/lib/xray/xray_fdr_logging_impl.h
  compiler-rt/lib/xray/xray_recursion_guard.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47696.149673.patch
Type: text/x-patch
Size: 77026 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180604/9caef3e6/attachment-0001.bin>


More information about the llvm-commits mailing list