[llvm] r333821 - [X86] Fix warning message for AVX5124FMAPS and AVX5124VNNIW instructions in the assembly parser.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 2 09:30:36 PDT 2018


Author: ctopper
Date: Sat Jun  2 09:30:36 2018
New Revision: 333821

URL: http://llvm.org/viewvc/llvm-project?rev=333821&view=rev
Log:
[X86] Fix warning message for AVX5124FMAPS and AVX5124VNNIW instructions in the assembly parser.

The caret was positioned on the wrong operand. It's too hard to get right so just put the caret at the beginning of the instruction.

Modified:
    llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp

Modified: llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp?rev=333821&r1=333820&r2=333821&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp Sat Jun  2 09:30:36 2018
@@ -2737,8 +2737,8 @@ bool X86AsmParser::validateInstruction(M
       StringRef RegName = X86IntelInstPrinter::getRegisterName(Src2);
       unsigned GroupStart = (Src2Enc / 4) * 4;
       unsigned GroupEnd = GroupStart + 3;
-      return Warning(Ops[Ops.size()-2]->getStartLoc(),
-                     "source register implicitly denotes '" +
+      return Warning(Ops[0]->getStartLoc(),
+                     "source register '" + RegName + "' implicitly denotes '" +
                      RegName.take_front(3) + Twine(GroupStart) + "' to '" +
                      RegName.take_front(3) + Twine(GroupEnd) +
                      "' source group");




More information about the llvm-commits mailing list