[PATCH] D47660: Fix support for distinguishing archive members by timestamp on Darwin.

[James Y Knight via Phabricator via llvm-commits]

jyknight added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/macosx/duplicate-archive-members/Makefile:4
+C_SOURCES := main.c
+MAKE_DSYM := NO
+
----------------
aprantl wrote:
> dsymutil also implements the same mechanism, so as an end-to-end test it wouldn't hurt to also allow the dSYM variant of this test to be run.
> 
> Does MAKE_DSYM=NO disable the dsym category for this test or does it just prevent the dwarf variant from also producing a dSYM?
Yeah, I'm not sure why that's there -- deleted.

I think I just copied it from another test's Makefile without thinking too hard. :)
AFAICT it doesn't even do anything -- the test infrastructure overrides MAKE_DSYM to NO or YES explicitly anyways, so this gets ignored. I suspect that it should be removed from all the other Makefiles too.


https://reviews.llvm.org/D47660