[PATCH] D47660: Fix support for distinguishing archive members by timestamp on Darwin.

[James Y Knight via Phabricator via llvm-commits]

jyknight created this revision.
jyknight added a reviewer: aprantl.
Herald added a subscriber: JDevlieghere.

On Darwin, the binary's symbol table points to debug info in object
files -- potentially object files within a static library. Such a
library may have multiple entries with the same name, distinguished
only by timestamp.

The code was already _attempting_ to handle this case (see the code in
ObjectContainerBSDArchive::Archive::FindObject which disambiguates via
timestamp). But, unfortunately, while the timestamp was taken into
account on the _first_ lookup, the result was then cached in a map
keyed only off of the path.

Added the timestamp to the cache, and added a test case.


https://reviews.llvm.org/D47660

Files:
  lldb/packages/Python/lldbsuite/test/macosx/duplicate-archive-members/Makefile
  lldb/packages/Python/lldbsuite/test/macosx/duplicate-archive-members/TestDuplicateMembers.py
  lldb/packages/Python/lldbsuite/test/macosx/duplicate-archive-members/a.c
  lldb/packages/Python/lldbsuite/test/macosx/duplicate-archive-members/main.c
  lldb/packages/Python/lldbsuite/test/macosx/duplicate-archive-members/sub1/a.c
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47660.149564.patch
Type: text/x-patch
Size: 7535 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180601/f7264beb/attachment.bin>