[PATCH] D47602: Correct aligment computation for shared object symbols

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 13:58:18 PDT 2018


pcc added inline comments.


================
Comment at: ELF/InputFiles.cpp:910
   if (Ret > UINT32_MAX)
     error(toString(this) + ": alignment too large: " +
           CHECK(Sym.getName(this->StringTable), this));
----------------
I was thinking that instead of erroring here you would return 0. Then you wouldn't need the special case for `SHN_ABS`.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47602





More information about the llvm-commits mailing list