[PATCH] D47648: ELF: Don't query a shared symbol's alignment unless necessary.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 13:31:03 PDT 2018


pcc added a comment.

That certainly makes sense for `Defined`, but maybe not so much for `SharedSymbol`, at least when we don't have any code which actually creates fake shared symbols. You'll note that there are already dependencies on there being an actual .so file, e.g. with `VerdefIndex`, and I reckon that it's probably better to depend on the .so fully rather than being in a half dependent state.


https://reviews.llvm.org/D47648





More information about the llvm-commits mailing list