[PATCH] D47604: Add isl C++ list iterators

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 12:08:01 PDT 2018


Meinersbur added a comment.

[suggestion] unit tests?



================
Comment at: include/polly/Support/ISLTools.h:22-42
+/// A set of list accessors which make the subsequent iterator implementation
+/// easier.
+inline isl::basic_set list_get(isl::basic_set_list list, long idx) {
+  return list.get_basic_set(idx);
+}
+inline isl::set list_get(isl::set_list list, long idx) {
+  return list.get_set(idx);
----------------
Meinersbur wrote:
> [suggestion] These are not meant to be used outside of `struct list_iterator`, correct? Hence you could put them into an anonymous namespace.
or `polly::detail` subnamespace


Repository:
  rPLO Polly

https://reviews.llvm.org/D47604





More information about the llvm-commits mailing list