[PATCH] D47424: [MIRParser] Add parser support for 'true' and 'false' i1s.

Roman Tereshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 11:22:12 PDT 2018


rtereshin added inline comments.


================
Comment at: lib/CodeGen/MIRParser/MIParser.cpp:1379
+        !(Token.range().startswith("true") ||
+          Token.range().startswith("false")))
+      return error("expected an integer literal");
----------------
Why startswith instead of direct comparisons? Is it going to parse `truee` as `true`?


Repository:
  rL LLVM

https://reviews.llvm.org/D47424





More information about the llvm-commits mailing list