[PATCH] D47631: [ValueTracking] Match select abs pattern when there's an sext involved

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 10:47:14 PDT 2018


craig.topper added inline comments.


================
Comment at: lib/Analysis/ValueTracking.cpp:4612
+    if ((match(TrueVal, MaybeSExtLHS) &&
+         match(FalseVal, m_Neg(MaybeSExtLHS))) ||
+        (match(FalseVal, MaybeSExtLHS) &&
----------------
Can we just check m_Neg(TrueVal)?


Repository:
  rL LLVM

https://reviews.llvm.org/D47631





More information about the llvm-commits mailing list