[PATCH] D47581: [LNT] Fix use of field index in daily report

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 07:48:32 PDT 2018


kristof.beyls added a comment.

In https://reviews.llvm.org/D47581#1119035, @john.brawn wrote:

> > Maybe the best way to test this is to add a helper function in tests/server/ui/V4Pages.py to extract the full content from a specific field from the table (i.e. including all HTML tags) and check against exact HTML content?
> > 
> > What do you think - would that be feasible and useful to implement?
>
> After trying some things I think it will be easier to extract just the destination of the links and check that those are correct, especially as it's just the destination of the links that was wrong.


That sounds like a reasonable approach to me too.


Repository:
  rL LLVM

https://reviews.llvm.org/D47581





More information about the llvm-commits mailing list