[PATCH] D46379: [ConstantFold] Turn off expression simplification for vector type

[Karl-Johan Karlsson via Phabricator via llvm-commits]

Ka-Ka added a comment.

In https://reviews.llvm.org/D46379#1118995, @spatel wrote:

> In https://reviews.llvm.org/D46379#1118803, @Ka-Ka wrote:
>
> > Do you think I should still include the negative testcase that you specified above even if the patch now only affect the GEP case?
>
>
> Yes - because the earlier revision would have caused a bug with no regression test coverage for it. Let's add that to be safe. Also, I'd prefer to use the utils/update_test_checks.py script on all tests because it makes maintenance easier. And as before, if you check in the baseline version of the test using trunk output, that's even better - we want to keep the tests in place even if the patch gets reverted for some reason.


Sure, I include the negative testcase in the file test/Analysis/ConstantFolding/gep-zeroinit-vector.ll

Do you want me to also remove the old testcase test/Transforms/LoopVectorize/X86/constant-fold.ll (that was only created for this issue) as the new one test/Analysis/ConstantFolding/gep-zeroinit-vector.ll replace it?


Repository:
  rL LLVM

https://reviews.llvm.org/D46379