[PATCH] D47590: DWARFAcceleratorTable: Add an iterator-based api for accessing names in the index

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Look fine to me



================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:376
+    /// string offset is not valid.
+    const char *getString() const {
+      uint32_t Off = StringOffset;
----------------
Have you considered wrapping this in a StringRef?


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:535
+    /// The current name in the Name Index.
+    uint32_t CurrentName;
+
----------------
CurrentName being an int feels weird, but it's consistent with the other iterator and I don't have a better suggestion.


Repository:
  rL LLVM

https://reviews.llvm.org/D47590