[PATCH] D47562: Add "(default)" to default options

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 31 06:01:39 PDT 2018


jhenderson added a comment.

Hi @ruiu,

I was just looking at this change, and I noticed one slight mistake in this: the --discard-none switch is not the default behaviour of LLD. If it were, the default DiscardPolicy would be DiscardPolicy::None, when in fact it is DiscardPolicy::Default and there's a difference in the behaviour between the two in `shouldKeepInSymtab`.


Repository:
  rL LLVM

https://reviews.llvm.org/D47562





More information about the llvm-commits mailing list