[PATCH] D47511: [AMDGPU] Construct memory clauses before RA

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 31 02:04:37 PDT 2018


vpykhtin accepted this revision.
vpykhtin added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Target/AMDGPU/SIFormMemoryClauses.cpp:242
+  RPT.advanceToNext();
+  GCNRegPressure MaxPressure = RPT.moveMaxPressure();
+  unsigned Occupancy = MaxPressure.getOccupancy(*ST);
----------------
rampitec wrote:
> vpykhtin wrote:
> > moveMaxPressure actually clears accumulated MaxPressure - is this intended?
> That is the only interface we made here ;) It does not really matter, as the next step will recreate MaxPressure. Take in mind that pressure cannot go down within the clause, only after. Therefor CurPressure is always a MaxPressure too while inside the clause.
ok, then. I will add something like getMaxPressure next time.


https://reviews.llvm.org/D47511





More information about the llvm-commits mailing list