[PATCH] D42109: [PowerPC] Follow-up to r322373 for materializing constants that set the CR

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai marked 2 inline comments as done.
nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:2516
+        else if (MRI->use_empty(MI.getOperand(0).getReg()))
+          NewImm = NewImm ? Immediate : 0;
+        else if (ImmChanged)
----------------
hfinkel wrote:
> Could it be the case that NewImm is non-zero while Immediate is zero? Does it matter? (I'm guessing not, but given that NewImm is set in a variety of ways above, it's not completely obvious to me).
None of the instructions that could take the immediate from zero to non-zero have a record-form so it doesn't matter. However, to make it clear, I'll add an assert.


Repository:
  rL LLVM

https://reviews.llvm.org/D42109