[PATCH] D47414: [llvm-objcopy] Fix null symbol handling

[Jake Ehrlich via llvm-commits]

Quick drop in. What I was thinking about before was to just never pass the
null symbol to remove or anything else. It can still be there it just
shouldn't be allowed to be updated or removed.

As for how the null section header should be treated we have to consider
large indexes before proceeding.

On Wed, May 30, 2018, 5:59 PM Paul Semel via Phabricator <
reviews at reviews.llvm.org> wrote:

> paulsemel added a comment.
>
> Ok, I'm getting back to you because I really think that we want to go
> forward on this one, as this fixes a really "big" bug.
>
> Are you guys totally convinced that we might keep this symbol ?
>
> If so, I will change the implementation, even though I truly think not
> exposing the symbol will simplify the future development of `llvm-objcopy`.
>
> cc: @jhenderson @alexshap
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D47414
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180531/4aee73a9/attachment.html>