[PATCH] D47505: [llvm-strip] Add -o option

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: test/tools/llvm-objcopy/strip-all.test:6-7
 
-# We run yaml2obj again rather than copy %t to avoid interfering
-# with llvm-objcopy's test (which potentially could have corrupted/updated the binary).
+# Verify that the previous llvm-objcopy's run has not modified the input.
+# RUN: cmp %t %t3
 
----------------
jhenderson wrote:
> I thought that we decided in a previous review not to do this, but instead to do what the old test is doing? Or am I misremembering?
I think you are misremembering. We decided to avoid what the old test was doing. {F6291787} The motivation was (if I'm not mistaken) that it's not really necessary to run yaml2obj twice and then do text matching twice. 


Repository:
  rL LLVM

https://reviews.llvm.org/D47505