[PATCH] D47514: [Target][NFC] Simplify `AssemblerPredicate`.

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added inline comments.


================
Comment at: lib/Target/Mips/MipsInstrInfo.td:238-239
 def IsNotNaCl    :    Predicate<"!Subtarget->isTargetNaCl()">;
-def UseTCCInDIV    :  AssemblerPredicate<"FeatureUseTCCInDIV">;
+def UseTCCInDIV    :  Predicate<"Subtarget->useTCCInDIV()">,
+                      AssemblerPredicate<"FeatureUseTCCInDIV">;
 def HasEVA       :    Predicate<"Subtarget->hasEVA()">,
----------------
UseTCCInDiv is purely an assembler feature. It controls the expansion of the div macro and has no bearing on CodeGen. It doesn't make sense to implement it for CodeGen.

The reason it has a variable in MipsSubtarget is because tablegen incorrectly generates an assignment to it in MipsSubtarget::ParseSubtargetFeatures() and it didn't seem worth it to stop it from doing that.


Repository:
  rL LLVM

https://reviews.llvm.org/D47514