[PATCH] D47505: [llvm-strip] Add -o option

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/strip-all.test:6-7
 
-# We run yaml2obj again rather than copy %t to avoid interfering
-# with llvm-objcopy's test (which potentially could have corrupted/updated the binary).
+# Verify that the previous llvm-objcopy's run has not modified the input.
+# RUN: cmp %t %t3
 
----------------
I thought that we decided in a previous review not to do this, but instead to do what the old test is doing? Or am I misremembering?


================
Comment at: tools/llvm-objcopy/StripOpts.td:11-12
+defm output : Eq<"o">,
+              MetaVarName<"output">,
+              HelpText<"Output file">;
+
----------------
paulsemel wrote:
> what about :
> ```
>  MetaVarName<"file">,
>  HelpText<"Output stripped file into <file>">;
> ```
I think we should avoid mentioning "stripped" in the help text, because it's possible even now to use switches to prevent any actual stripping from occurring.


Repository:
  rL LLVM

https://reviews.llvm.org/D47505